Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zlib,stream: use “official” util.types typechecks #19602

Closed
wants to merge 1 commit into from
Closed

zlib,stream: use “official” util.types typechecks #19602

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

The old variants have been deprecated since b20af80.

Refs: #18415

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@addaleax
zlib,stream: use “official” util.types typechecks
f265275 
The old variants have been deprecated since b20af80.

Refs: nodejs#18415
@nodejs-github-bot nodejs-github-bot added stream Issues and PRs related to the stream subsystem. zlib Issues and PRs related to the zlib subsystem. labels Mar 26, 2018
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/17178/

@lpinca lpinca added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 27, 2018
@trivikr
Copy link
Member

trivikr commented Mar 28, 2018

Landed in e765257

@trivikr trivikr closed this Mar 28, 2018
trivikr pushed a commit that referenced this pull request Mar 28, 2018
@addaleax @trivikr
zlib,stream: use “official” util.types typechecks
e765257 
The old variants have been deprecated since b20af80.

Refs: #18415

PR-URL: #19602
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax addaleax deleted the no-util-types-zlib branch March 29, 2018 21:47
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 29, 2018
@targos
Copy link
Member

targos commented Apr 2, 2018

Depends on #18415 to land on v9.x-staging

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
@addaleax @BridgeAR
zlib,stream: use “official” util.types typechecks
34ca1ed 
The old variants have been deprecated since b20af80.

Refs: nodejs#18415

PR-URL: nodejs#19602
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@starkwang starkwang starkwang approved these changes

Assignees
No one assigned
Labels
stream Issues and PRs related to the stream subsystem. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@addaleax @trivikr @targos @jasnell @lpinca @TimothyGu @cjihrig @joyeecheung @starkwang @nodejs-github-bot