-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update AUTHORS list #19768
doc: update AUTHORS list #19768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some entries the corresponding name of the person can be found in their github profile. Should we always use that name?
AUTHORS
Outdated
Ujjwal Sharma <usharma1998@gmail.com> | ||
Wei-Wei Wu <wuxx1045@umn.edu> | ||
punteek <prateek1@ucla.edu> | ||
Tobias Nießen <tniessen@users.noreply.github.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This entry should be reflected in the mailmap.
AUTHORS
Outdated
Tobias Nießen <tniessen@users.noreply.github.com> | ||
Ken Lin <ken23421@gmail.com> | ||
Piotr Grzesik <pj.grzesik@gmail.com> | ||
feugy <damien.feugas@gmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name is "Damien Feugas" and should be reflected as such (he has a middle name but I guess that is not important?).
Updated with names found in github profiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -3,6 +3,8 @@ Aaron Heckmann <aaron.heckmann@gmail.com> <aaron.heckmann+github@gmail.com> | |||
Aayush Ahuja <aayush.a@directi.com> aayush.a <aayush.a@directi.com> | |||
Abe Fettig <abefettig@gmail.com> <abe@fettig.net> | |||
Akito Ito <akito0107@gmail.com> <akito_ito@r.recruit.co.jp> | |||
Alejandro Estrada <estrada9166@gmail.com> | |||
Alejandro Estrada <estrada9166@gmail.com> <estrada9166@hotmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has to be like that AFAICT. First entry for the name (it is lowercase in the commit log). Second entry for the email alias.
PR-URL: nodejs#19768 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Landed in dca09a7 |
PR-URL: #19768 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
No description provided.