doc: add instructions to update local git config #19777
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this code change updates pull-requests.md to instruct developers to update their local git config instead of global. This way their global git config won't be overwritten if they use different email ID for work or personal or non-Github projects
vsemozhetbyt
added
the
meta
danbev
approved these changes
Apr 4, 2018
lpinca
approved these changes
Apr 4, 2018
| @@ -86,6 +74,18 @@ $ git remote add upstream https://github.com/nodejs/node.git | |||
| $ git fetch upstream | |||
| ``` | |||
|
|
|||
| It is recommended to configure `git` so that it knows | |||
| who you are: | |||
There was a problem hiding this comment.
Nit: this fits in the previous line.
trivikr
added
the
author ready
jasnell
approved these changes
Apr 4, 2018
|
Landed in 8b1db6d |
trivikr
added a commit
that referenced
this pull request
Apr 6, 2018
this code change updates pull-requests.md to instruct developers to update their local git config instead of global. This way their global git config won't be overwritten if they use different email ID for work or personal or non-Github projects PR-URL: #19777 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 6, 2018
this code change updates pull-requests.md to instruct developers to update their local git config instead of global. This way their global git config won't be overwritten if they use different email ID for work or personal or non-Github projects PR-URL: #19777 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code change updates pull-requests.md to instruct developers to
update their local git config instead of global. This way their global
git config won't be overwritten if they use different email ID for work
or personal or non-Github projects
The doc with edits can be viewed in the private branch here
Checklist