net,stream: remove DuplexBase #19779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DuplexBase` was added to prevent the "no-half-open enforcer" from being inherited by `net.Socket`. The main reason to use it instead of `Duplex` was that it allowed to not copy the options object but since commit 5e3f516 the options object is copyed anyway so it is no longer useful.
nodejs-github-bot
added
build
|
This basically reverts df07169. |
addaleax
approved these changes
Apr 3, 2018
lib/_stream_duplex.js
Outdated
| util.inherits(Duplex, Readable); | ||
|
|
||
| { | ||
| // avoid scope creep, the keys array can then be collected |
There was a problem hiding this comment.
I don’t know about you, but “scope creep” means something pretty different for me… ;)
lib/net.js
Outdated
| else | ||
| options = util._extend({}, options); | ||
|
|
||
| const aho = options.allowHalfOpen; |
lpinca
force-pushed
the
remove/duplex-base
branch
from
60d96f7
to
5c397d9
Compare
danbev
approved these changes
Apr 4, 2018
jasnell
approved these changes
Apr 4, 2018
|
Landed in 496d602. |
lpinca
added a commit
that referenced
this pull request
Apr 6, 2018
`DuplexBase` was added to prevent the "no-half-open enforcer" from being inherited by `net.Socket`. The main reason to use it instead of `Duplex` was that it allowed to not copy the options object but since commit 5e3f516 the options object is copyed anyway so it is no longer useful. PR-URL: #19779 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2018
`DuplexBase` was added to prevent the "no-half-open enforcer" from being inherited by `net.Socket`. The main reason to use it instead of `Duplex` was that it allowed to not copy the options object but since commit 5e3f516 the options object is copyed anyway so it is no longer useful. PR-URL: #19779 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DuplexBasewas added to prevent the "no-half-open enforcer" frombeing inherited by
net.Socket. The main reason to use it insteadof
Duplexwas that it allowed to not copy the options object butsince commit 5e3f516 the options object is copyed anyway so it is
no longer useful.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes