Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: verify multiple init via well-known symbol #19875

Closed
wants to merge 1 commit into from
Closed

test: verify multiple init via well-known symbol #19875

wants to merge 1 commit into from

Conversation

gabrielschulhof
Copy link
Contributor

Re-require() the addon after clearing its cache to ensure that it is
re-initialized via the well-known symbol.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

test: verify multiple init via well-known symbol
5fd931f 
Re-`require()` the addon after clearing its cache to ensure that it is
re-initialized via the well-known symbol.
@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Apr 8, 2018
@gabrielschulhof gabrielschulhof mentioned this pull request Apr 8, 2018
Closed
3 tasks
@BridgeAR
Copy link
Member

BridgeAR commented Apr 8, 2018

CI https://ci.nodejs.org/job/node-test-pull-request/14128/

@BridgeAR BridgeAR added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Apr 8, 2018
@gabrielschulhof
Copy link
Contributor Author

Landed in 244af7a.

gabrielschulhof pushed a commit that referenced this pull request Apr 9, 2018
test: verify multiple init via well-known symbol
244af7a 
Re-`require()` the addon after clearing its cache to ensure that it is
re-initialized via the well-known symbol.

PR-URL: #19875
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@gabrielschulhof gabrielschulhof deleted the multiple-require branch April 9, 2018 01:32
targos pushed a commit that referenced this pull request Apr 12, 2018
@targos
test: verify multiple init via well-known symbol
aa5de9d 
Re-`require()` the addon after clearing its cache to ensure that it is
re-initialized via the well-known symbol.

PR-URL: #19875
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gabrielschulhof @BridgeAR @Trott @cjihrig @nodejs-github-bot