errors: alter ERR_INVALID_CURSOR_POS #19960
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
errors
Is this forgotten by chance?) |
vsemozhetbyt
added
the
readline
|
@vsemozhetbyt not relevant to this commit – thanks for spotting! removed |
jasnell
approved these changes
Apr 12, 2018
trivikr
approved these changes
Apr 12, 2018
BridgeAR
approved these changes
Apr 15, 2018
BridgeAR
added
semver-major
|
This needs at least one more TSC approval before it can land. |
lpinca
approved these changes
Apr 16, 2018
|
@davidmarkclements can you please rebase when you have some time? Thank you. |
|
Would you be so kind to remove the merge commit? |
|
yes sorry - I used the github interface hoping it would rebase.. it doesn't – will fix |
changes the base instance for ERR_INVALID_CURSOR_POS from Error to TypeError as a more accurate representation of the error.
|
@lpinca - rebased |
|
Re-running Linux: https://ci.nodejs.org/job/node-test-commit-linux/18063/ |
|
Landed in 31d6cec. |
lpinca
pushed a commit
that referenced
this pull request
Apr 17, 2018
Changes the base instance for ERR_INVALID_CURSOR_POS from Error to TypeError as a more accurate representation of the error. PR-URL: #19960 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 17, 2018
Changes the base instance for ERR_INVALID_CURSOR_POS from Error to TypeError as a more accurate representation of the error. PR-URL: #19960 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes the base instance for ERR_INVALID_CURSOR_POS
from Error to TypeError as a more accurate representation
of the error.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes