test: fix http-agent-destroyed-socket cb not firing #20006
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A whole part of the test-http-agent-destroyed-socket test was not running as the semantics of http events changed slightly and were no longer triggering the expected event. Instead listen to the same event on the socket to verify that the code being tested is still working as expected.
apapirovski
commented
Apr 13, 2018
| // socket manually at just the right time, but at Voxer we have | ||
| // seen cases where the socket is destroyed by non-user code | ||
| // then handed out again by an agent *before* the 'close' event | ||
| // is triggered. |
There was a problem hiding this comment.
This comment is no longer relevant hence the removal.
|
Ping @nodejs/http @nodejs/http2 @nodejs/streams |
jasnell
approved these changes
Apr 13, 2018
lpinca
approved these changes
Apr 13, 2018
| @@ -47,21 +47,9 @@ const server = http.createServer(common.mustCall((req, res) => { | |||
| request1.socket.on('close', common.mustCall()); | |||
There was a problem hiding this comment.
Nit: I guess this is redundant now.
There was a problem hiding this comment.
Ah, good point. Will fix in the morning. Thanks!
trivikr
approved these changes
Apr 14, 2018
BridgeAR
added
the
author ready
|
Landed in 15e136d. |
lpinca
pushed a commit
that referenced
this pull request
Apr 17, 2018
A whole part of the test-http-agent-destroyed-socket test was not running as the semantics of http events changed slightly and were no longer triggering the expected event. Instead listen to the same event on the socket to verify that the code being tested is still working as expected. PR-URL: #20006 Fixes: #8613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 17, 2018
A whole part of the test-http-agent-destroyed-socket test was not running as the semantics of http events changed slightly and were no longer triggering the expected event. Instead listen to the same event on the socket to verify that the code being tested is still working as expected. PR-URL: #20006 Fixes: #8613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A whole part of the test-http-agent-destroyed-socket test was not running as the semantics of http events changed slightly and were no longer triggering the expected event. Instead listen to the same event on the socket to verify that the code being tested is still working as expected.
Fixes: #8613
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes