Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove lint from test-ci on windows #2004

Closed
wants to merge 1 commit into from

Conversation

jbergstroem
Copy link
Member

This should've been part of #1965 but I didn't do my windows homework.

/R=@nodejs/build, @orangemocha

@jbergstroem jbergstroem added windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Jun 17, 2015
@rvagg
Copy link
Member

rvagg commented Jun 17, 2015

derp, lgtm

@orangemocha
Copy link
Contributor

👍

jbergstroem added a commit that referenced this pull request Jun 19, 2015
PR-URL: #2004
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
@jbergstroem
Copy link
Member Author

Merged in c5353d7. Thanks for reviewing.

@rvagg rvagg mentioned this pull request Jun 19, 2015
rvagg pushed a commit to rvagg/io.js that referenced this pull request Jul 3, 2015
PR-URL: nodejs#2004
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
jbergstroem added a commit that referenced this pull request Jul 3, 2015
PR-URL: #2004
PORT-PR-URL: #2101
PORT-FROM: c5353d7
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Alexis Campailla <alexis@janeasystems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants