-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test for loading read-only modules #20138
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
'use strict'; | ||
|
||
const common = require('../common'); | ||
|
||
if (!common.isWindows) { | ||
// TODO: Similar checks on *nix-like systems (e.g using chmod or the like) | ||
common.skip('test only runs on Windows'); | ||
} | ||
|
||
const assert = require('assert'); | ||
const fs = require('fs'); | ||
const path = require('path'); | ||
const cp = require('child_process'); | ||
|
||
const tmpdir = require('../common/tmpdir'); | ||
tmpdir.refresh(); | ||
|
||
// Create readOnlyMod.js and set to read only | ||
const readOnlyMod = path.join(tmpdir.path, 'readOnlyMod'); | ||
const readOnlyModRelative = path.relative(__dirname, readOnlyMod); | ||
const readOnlyModFullPath = `${readOnlyMod}.js`; | ||
|
||
fs.writeFileSync(readOnlyModFullPath, 'module.exports = 42;'); | ||
|
||
// Removed any inherited ACEs, and any explicitly granted ACEs for the | ||
// current user | ||
cp.execSync( | ||
`icacls.exe "${readOnlyModFullPath}" /inheritance:r /remove "%USERNAME%"`); | ||
|
||
// Grant the current user read & execute only | ||
cp.execSync(`icacls.exe "${readOnlyModFullPath}" /grant "%USERNAME%":RX`); | ||
|
||
let except = null; | ||
try { | ||
// Attempt to load the module. Will fail if write access is required | ||
require(readOnlyModRelative); | ||
} catch (err) { | ||
except = err; | ||
} | ||
|
||
// Remove the expliclty granted rights, and reenable inheritance | ||
cp.execSync( | ||
`icacls.exe "${readOnlyModFullPath}" /remove "%USERNAME%" /inheritance:e`); | ||
|
||
// Delete the test module (note: tmpdir should get cleaned anyway) | ||
fs.unlinkSync(readOnlyModFullPath); | ||
|
||
assert.ifError(except); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we simply end the test here with
require(readOnlyModRelative);
? Is the cleanup required?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing as the test must explicitly remove any write access to the file, I figure clean up could potentially hit issues if I don't restore the default permissions afterwards (per line 42). Once that is done, removing the file isn't strictly necessary (line 46), but I see no harm in it (per the comment note above it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, nothing wrong with the tear down, I just think it's not needed astmpdir.refresh()
purges everything.