crypto: use kNoAuthTagLength in InitAuthenticated #20225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
jasnell
approved these changes
Apr 23, 2018
danbev
approved these changes
Apr 24, 2018
bnoordhuis
approved these changes
Apr 24, 2018
src/node_crypto.cc
Outdated
| int auth_tag_len = args[2].As<v8::Int32>()->Value(); | ||
| unsigned int auth_tag_len; | ||
| if (args[2]->IsUint32()) { | ||
| auth_tag_len = args[2]->Uint32Value(); |
There was a problem hiding this comment.
Can you use the overload that takes a Local<Context> or use the args[2].As<Uint32>()->Value() idiom?
BridgeAR
added
the
author ready
bnoordhuis
approved these changes
Apr 24, 2018
src/node_crypto.cc
Outdated
| @@ -2705,9 +2705,9 @@ void CipherBase::Init(const FunctionCallbackInfo<Value>& args) { | |||
| // represent a valid length at this point. | |||
| unsigned int auth_tag_len; | |||
| if (args[2]->IsUint32()) { | |||
| auth_tag_len = args[2]->Uint32Value(); | |||
| auth_tag_len = args[2].As<v8::Uint32>()->Value(); | |||
There was a problem hiding this comment.
Can you add using v8::Uint32; and using v8::Int32; at the top?
|
Should this be backported to |
tniessen
added a commit
to tniessen/node
that referenced
this pull request
May 13, 2018
PR-URL: nodejs#20225 Refs: nodejs#20039 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
tniessen
added a commit
to tniessen/node
that referenced
this pull request
May 13, 2018
PR-URL: nodejs#20225 Refs: nodejs#20039 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Merged
targos
added
backported-to-v10.x
and removed
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @bnoordhuis in #20039, this changes
InitAuthenticatedto accept anunsigned int auth_tag_len.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes