docs: improve process event headers #20312
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The headers should be handled as all others as well and just indicate all arguments.
vsemozhetbyt
approved these changes
Apr 26, 2018
| @@ -82,16 +84,15 @@ process.on('exit', (code) => { | |||
| added: v0.5.10 | |||
| --> | |||
|
|
|||
| * `message` {Object} a parsed JSON object or primitive value. | |||
There was a problem hiding this comment.
I am not sure if we should explicitly enumerate "primitive values" here. What types can they be?
{Object | boolean | number | string | null }?
It seems any does not suffice as there hardly can be undefined or symbol.
There was a problem hiding this comment.
Hm, I have no strong opinion. @Trott maybe?
There was a problem hiding this comment.
Since I did not change the current state, I guess this can be addressed at a different point of time as well?
|
@nodejs/documentation PTAL |
jasnell
approved these changes
Apr 27, 2018
BridgeAR
added
the
author ready
trivikr
approved these changes
Apr 28, 2018
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Apr 29, 2018
The headers should be handled as all others as well and just indicate all arguments. PR-URL: nodejs#20312 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
|
Landed in b92c656 |
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
The headers should be handled as all others as well and just indicate all arguments. PR-URL: #20312 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The headers should be handled as all others as well and just indicate
all arguments.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes