Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: reduce require calls in http2/core #20422

Closed
wants to merge 1 commit into from
Closed

http2: reduce require calls in http2/core #20422

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Apr 30, 2018

This commit removes unnecesary requires of http and internal/util in
http2/core.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@danbev
http2: reduce require calls in http2/core
c929963 
This commit removes unnecesary requires of http and internal/util in
http2/core.js
@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x http2 Issues or PRs related to the http2 subsystem. labels Apr 30, 2018
@danbev
Copy link
Contributor Author

danbev commented Apr 30, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/14596/

@BridgeAR
Copy link
Member

-0 as this is mainly churn out of my perspective.

@danbev
Copy link
Contributor Author

danbev commented May 2, 2018

Landed in 557f570.

@danbev danbev closed this May 2, 2018
@danbev danbev deleted the http2_core_requires branch May 2, 2018 06:46
danbev added a commit to danbev/node that referenced this pull request May 2, 2018
@danbev
http2: reduce require calls in http2/core
557f570 
This commit removes unnecesary requires of http and internal/util in
http2/core.js

PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 4, 2018
@danbev @MylesBorins
http2: reduce require calls in http2/core
42bbaa3 
This commit removes unnecesary requires of http and internal/util in
http2/core.js

PR-URL: #20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 8, 2018
Merged
kjin pushed a commit to kjin/node that referenced this pull request Aug 23, 2018
@danbev @kjin
http2: reduce require calls in http2/core
27a337a 
This commit removes unnecesary requires of http and internal/util in
http2/core.js

PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request Sep 11, 2018
@danbev @kjin
http2: reduce require calls in http2/core
1f55a39 
This commit removes unnecesary requires of http and internal/util in
http2/core.js

PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request Sep 19, 2018
@danbev @kjin
http2: reduce require calls in http2/core
1b7d030 
This commit removes unnecesary requires of http and internal/util in
http2/core.js

PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kjin pushed a commit to kjin/node that referenced this pull request Oct 16, 2018
@danbev @kjin
http2: reduce require calls in http2/core
d9efc87 
This commit removes unnecesary requires of http and internal/util in
http2/core.js

PR-URL: nodejs#20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Oct 17, 2018
@danbev @BethGriggs
http2: reduce require calls in http2/core
74192dd 
This commit removes unnecesary requires of http and internal/util in
http2/core.js

Backport-PR-URL: #22850
PR-URL: #20422
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Oct 30, 2018
Merged
@beevelop beevelop mentioned this pull request Nov 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@lpinca lpinca lpinca approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @BridgeAR @apapirovski @lpinca @TimothyGu @trivikr @nodejs-github-bot