n-api: fix napi_property_descriptor documentation #20433
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
FWIW, the last fix is also done here: #20430 |
|
@vsemozhetbyt whoops - I'll remove that part. |
gabrielschulhof
force-pushed
the
20421-fix-napi-property-descriptor
branch
from
393be56
to
9af5c4f
Compare
|
@vsemozhetbyt fixed. |
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
vsemozhetbyt
added
the
fast-track
mhdawson
reviewed
May 3, 2018
doc/api/n-api.md
Outdated
| @@ -957,7 +956,7 @@ To define a class so that new instances can be created (often used with | |||
| napi_value Init(napi_env env, napi_value exports) { | |||
| napi_status status; | |||
| napi_property_descriptor properties[] = { | |||
| { "value", NULL, GetValue, SetValue, 0, napi_default, 0 }, | |||
| { "value", 0, 0, GetValue, SetValue, 0, napi_default, 0 }, | |||
There was a problem hiding this comment.
I thought the suggestion was to use NULL instead of 0, just wondering why you went the other way?
There was a problem hiding this comment.
Oh, right. I thought it would be more consistent, but you're right. This is plain C. I should actually use NULL everywhere – though that might expand the scope of the PR.
I'll add NULLs everywhere this PR touches, and do another sweep to make sure that the entire doc says NULL.
gabrielschulhof
force-pushed
the
20421-fix-napi-property-descriptor
branch
from
9af5c4f
to
72575f2
Compare
|
@mhdawson I have updated the affected parts to show |
cjihrig
approved these changes
May 5, 2018
BridgeAR
added
the
author ready
|
Landed in 4692cf4. |
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
May 6, 2018
PR-URL: nodejs#20433 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
PR-URL: #20433 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 8, 2018
PR-URL: #20433 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
May 9, 2018
PR-URL: #20433 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes