Revert "stream: prevent 'end' to be emitted after 'error'"

[mscdex]

Fixes: #20334

CI: https://ci.nodejs.org/job/node-test-pull-request/14609/

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[mscdex]

FWIW I'm targeting master here because I think we need a better plan on how to more easily transition existing code (e.g. replacing existing uses of 'end' with some other event that acts as a "error or not" end event, such as 'close' or similar as I suggested in the referenced issue).

[mscdex]

/cc @nodejs/streams

[mcollina]

I’m -1 to land this on master. I’m +1 to land this on node 10.0.0.

[mscdex]

/cc @nodejs/collaborators

[mcollina]

LGTM, I'll redo the PR.

Ref: #20503.

[addaleax]

@mcollina I’d really really like to not get in a habit of reverting commits only on release branches – if there is breakage that is significant enough to revert something, then we should try to keep master clear of that as well imo.

Edit: Removing the author ready label because there was a -1 on landing this on its target branch.

[mscdex]

@mcollina I'm confused a bit with your explicit approval. Does that mean you are no longer -1 on landing this on master?

[mcollina]

Yes exactly. I’ll resend the PR as soon as this land, but we need to revert it in 10 (it seems this causes some other issues). I agree this was rushed in.

[addaleax]

Landed in 8f6ab9f

[ronag]

@addaleax re-open open v11?

[addaleax]

@ronag As I understand it, @mcollina said that he’d open another fix for the original issue. Re-opening PRs doesn’t work always well with our release tooling, unfortunately.

[mcollina]

Done in #20571.