test: improve coverage for readline.Interface #20704
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests in parallel/test-readline-interface to increase coverage
cjihrig
approved these changes
May 15, 2018
trivikr
approved these changes
May 15, 2018
jasnell
approved these changes
May 15, 2018
jasnell
reviewed
May 15, 2018
| assert.strictEqual(cursorPos.rows, 0); | ||
| assert.strictEqual(cursorPos.cols, 19); | ||
|
|
||
| // back one character |
There was a problem hiding this comment.
tiniest of nits: Can you use caps for the first letter in each comment.
There was a problem hiding this comment.
Fixed them. Thanks 😄
BridgeAR
approved these changes
May 18, 2018
BridgeAR
added
author ready
jasnell
pushed a commit
that referenced
this pull request
May 23, 2018
Add tests in parallel/test-readline-interface to increase coverage PR-URL: #20704 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
landed in f51c44d |
targos
pushed a commit
that referenced
this pull request
May 25, 2018
Add tests in parallel/test-readline-interface to increase coverage PR-URL: #20704 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests in parallel/test-readline-interface to increase coverage
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes