build: export openssl TLSv1 methods again #20712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
addaleax
approved these changes
May 14, 2018
tniessen
approved these changes
May 14, 2018
BridgeAR
approved these changes
May 14, 2018
BridgeAR
added
the
author ready
jasnell
approved these changes
May 14, 2018
|
@bnoordhuis since they are deprecated upstream do we need doc deprecate them or something along those lines so that we start to prepare for when they may not be available at all? |
cjihrig
approved these changes
May 14, 2018
danbev
approved these changes
May 15, 2018
I'd say no, we don't do that for other dependencies either. I opened this PR to get Windows on par again with UNIX platforms, where they're still exported. |
Upstream deprecated them and moved them into categories of their own. Add those categories to the export list. Node.js doesn't use them but some add-ons do. Fixes: nodejs#20369 PR-URL: nodejs#20712 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nie�en <tniessen@tnie.de>
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
Upstream deprecated them and moved them into categories of their own. Add those categories to the export list. Node.js doesn't use them but some add-ons do. Fixes: #20369 PR-URL: #20712 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nie�en <tniessen@tnie.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream deprecated them and moved them into categories of their own.
Add those categories to the export list. Node.js doesn't use them but
some add-ons do.
Fixes: #20369
CI: https://ci.nodejs.org/job/node-test-commit/18469/