Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl,test: fix global check #20717

Closed
wants to merge 3 commits into from
Closed

repl,test: fix global check #20717

wants to merge 3 commits into from

Commits on May 14, 2018

  1. test: remove untested knownGlobals 

    These values are all non-enumerable and will never be checked.
By removing them, we make sure they will not become enumerable
unnoticed.
    @BridgeAR
    BridgeAR committed May 14, 2018
    Configuration menu
    Copy the full SHA
    52eb603 View commit details
    Browse the repository at this point in the history

  2. repl: make console, module and require non-enumerable 

    This aligns these globals with the regular context.
    @BridgeAR
    BridgeAR committed May 14, 2018
    Configuration menu
    Copy the full SHA
    e0ffaf6 View commit details
    Browse the repository at this point in the history

  3. test: remove common.globalCheck 

    This flag is partially used in tests where it was not necessary and
it is always possible to replace this flag with
`common.allowGlobals`. This makes sure all globals are truly tested
for.
    @BridgeAR
    BridgeAR committed May 14, 2018
    Configuration menu
    Copy the full SHA
    6af7bda View commit details
    Browse the repository at this point in the history