Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src,http2: refactor + generalize http2 debugging #20987

Closed
wants to merge 4 commits into from
Closed

src,http2: refactor + generalize http2 debugging #20987

wants to merge 4 commits into from

Commits on May 27, 2018

  1. src: implement debug output utilities 

    Implement utilities for easier debugging of Node.js core code,
inspired by the HTTP/2 debugging code. Debugging is, however,
implemented at runtime rather than at compile time, controlled
through a new `NODE_DEBUG_NATIVE=categories` environment variable.

The runtime overhead in the debugging-disabled case amounts to
1 well-cachable one-byte read per debug call.
    @addaleax
    addaleax committed May 27, 2018
    Configuration menu
    Copy the full SHA
    096bb72 View commit details
    Browse the repository at this point in the history

  2. [squash] be more active about telling the compiler what to do

    @addaleax
    addaleax committed May 27, 2018
    Configuration menu
    Copy the full SHA
    d0f3fc4 View commit details
    Browse the repository at this point in the history

  3. [squash] fix linter error

    @addaleax
    addaleax committed May 27, 2018
    Configuration menu
    Copy the full SHA
    55d6a3b View commit details
    Browse the repository at this point in the history

  4. http2: switch to new runtime-controlled debugging system 

    Remove `--debug-http2` as a compile-time feature and
make all debug statements available using `NODE_DEBUG_NATIVE=http2`
at runtime.

This probably makes the debugging-enabled case a bit slower due to
additional string concatenations, but switching to a runtime-checking
system makes debugging more flexible and can be applied more easily
to other parts of the source code as well.
    @addaleax
    addaleax committed May 27, 2018
    Configuration menu
    Copy the full SHA
    a2a9e9c View commit details
    Browse the repository at this point in the history