Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix typo in addons.md #21137

Closed
wants to merge 1 commit into from
Closed

doc: fix typo in addons.md #21137

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 5, 2018

"across version of Node.js" -> "across versions of Node.js"

Checklist

"across version of Node.js" -> "across versions of Node.js"
@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations. labels Jun 5, 2018
@vsemozhetbyt vsemozhetbyt added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jun 5, 2018
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@Trott
Copy link
Member Author

Trott commented Jun 6, 2018

Trott added a commit to Trott/io.js that referenced this pull request Jun 6, 2018
"across version of Node.js" -> "across versions of Node.js"

PR-URL: nodejs#21137
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jun 6, 2018

Landed in aa08cf1

@Trott Trott closed this Jun 6, 2018
MylesBorins pushed a commit that referenced this pull request Jun 6, 2018
"across version of Node.js" -> "across versions of Node.js"

PR-URL: #21137
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 6, 2018
@Trott Trott deleted the homeward-7 branch January 13, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants