Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make url-util-format engine agnostic #21141

Closed
wants to merge 2 commits into from

Commits on Jun 4, 2018

  1. test: make url-util-format engine agnostic

    test-util-format checks the message of an error that is
    generated by the JavaScript engine. Error messages that change in the
    underlying JavaScript engine should not be breaking changes in Node.js
    and therefore should not cause tests to fail. Remove the message check
    and replace it with a check of the type of the Error object along with
    the absence of a `code` property. (If a `code` property were present, it
    would indicate that the error was coming from Node.js rather than the
    JavaScript engine.)
    
    This also makes this test usable without modification in the ChakraCore
    fork of Node.js.
    Trott committed Jun 4, 2018
    Configuration menu
    Copy the full SHA
    cb6e68e View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2018

  1. squash! cjihrig nit

    Trott committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    ec4cf56 View commit details
    Browse the repository at this point in the history