Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix some typos in deprecations.md and vm.md #21569

Closed
wants to merge 1 commit into from
Closed

doc: fix some typos in deprecations.md and vm.md #21569

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@vsemozhetbyt build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/169/pipeline

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 27, 2018
@vsemozhetbyt vsemozhetbyt added vm Issues and PRs related to the vm subsystem. deprecations Issues and PRs related to deprecations. labels Jun 27, 2018
@vsemozhetbyt
Copy link
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 27, 2018
@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 28, 2018
vsemozhetbyt added a commit that referenced this pull request Jun 28, 2018
@vsemozhetbyt
doc: fix some typos in deprecations.md and vm.md
3d04e6c 
PR-URL: #21569
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
@vsemozhetbyt
Copy link
Contributor Author

Landed in 3d04e6c
Thank you for the reviews.

@vsemozhetbyt vsemozhetbyt deleted the doc-fix-typos branch June 28, 2018 06:52
targos pushed a commit that referenced this pull request Jun 28, 2018
@vsemozhetbyt @targos
doc: fix some typos in deprecations.md and vm.md
51a434f 
PR-URL: #21569
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
@targos targos mentioned this pull request Jul 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@starkwang starkwang starkwang approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vsemozhetbyt @nodejs-github-bot @lpinca @cjihrig @starkwang