Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: removing redundant checks in is* functions #2179

Closed

Conversation

thefourtheye
Copy link
Contributor

When Object.prototype.toString is used to determine the type, we don't
have to explicitly check for other types. This patch removes the
redundant checks like that.

When Object.prototype.toString is used to determine the type, we don't
have to explicitly check for other types. This patch removes the
redundant checks like that.
@cjihrig
Copy link
Contributor

cjihrig commented Jul 14, 2015

LGTM

1 similar comment
@targos
Copy link
Member

targos commented Jul 14, 2015

LGTM

@Fishrock123
Copy link
Contributor

Ya LGTM, I don't remember why I didn't do this when I was looking at util.is*..

@brendanashworth brendanashworth added the util Issues and PRs related to the built-in util module. label Jul 14, 2015
@Fishrock123
Copy link
Contributor

@Fishrock123 Fishrock123 self-assigned this Jul 16, 2015
@thefourtheye
Copy link
Contributor Author

@Fishrock123 The CI failures are not related to this change :-)

@thefourtheye
Copy link
Contributor Author

@Fishrock123 Can this be landed?

@Fishrock123
Copy link
Contributor

Yep, was LGTM if the CI was good. (it is)

thefourtheye added a commit that referenced this pull request Jul 21, 2015
When Object.prototype.toString is used to determine the type, we don't
have to explicitly check for other types. This patch removes the
redundant checks like that.

PR-URL: #2179

Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@thefourtheye
Copy link
Contributor Author

Thanks folks. Landed at 6391f4d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants