Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buffer: remove superfluous assignment #21844

Closed
wants to merge 1 commit into from
Closed

buffer: remove superfluous assignment #21844

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

The value of str_length doesn't need to be assigned here, the next statement will take care of that.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@tniessen tniessen requested a review from BridgeAR July 17, 2018 00:57
@nodejs-github-bot
Copy link
Collaborator

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/289/pipeline

@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. labels Jul 17, 2018
@addaleax
Copy link
Member

I’d be okay with fast-tracking this.

CI: https://ci.nodejs.org/job/node-test-pull-request/15906/

@tniessen
Copy link
Member Author

tniessen commented Jul 17, 2018 •
edited
Loading

Anyone else? (Not sure whether the PR author can approve fast-tracking.)
Edit: @addaleax, @targos (and myself) approved fast-tracking.

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 17, 2018
@tniessen
Copy link
Member Author

Landed in 3504850.

@tniessen tniessen closed this Jul 17, 2018
tniessen added a commit that referenced this pull request Jul 17, 2018
@tniessen
buffer: remove superfluous assignment
3504850 
PR-URL: #21844
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jul 18, 2018
@tniessen @targos
buffer: remove superfluous assignment
576f1ea 
PR-URL: #21844
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jul 18, 2018
Merged
This was referenced Jul 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@hiroppy hiroppy hiroppy approved these changes

@JungMinu JungMinu JungMinu approved these changes

@BridgeAR BridgeAR Awaiting requested review from BridgeAR

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tniessen @nodejs-github-bot @addaleax @jasnell @targos @cjihrig @hiroppy @JungMinu