Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update setTimeout on file test/internet/test-net-connect-unref.js to use common.platformTimeout #21969

Closed
wants to merge 3 commits into from
Closed

test: update setTimeout on file test/internet/test-net-connect-unref.js to use common.platformTimeout #21969

wants to merge 3 commits into from

Conversation

conectado
Copy link
Contributor

Hi!

This is my first PR 😄 I'm sorry if I make any mistake.

This commit updates the time used on the timeOut function to confonform to the recomendation given by the guide on writing tests.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jul 25, 2018
@Trott
Copy link
Member

Trott commented Jul 25, 2018

Even better IMO would be to remove the setTimeout() line entirely. The test will timeout via the tools/test.py wrapper if it ever stops working.

@Trott
Copy link
Member

Trott commented Jul 25, 2018

Also: Welcome @conectado! Thanks for the pull request!

@conectado
Copy link
Contributor Author

conectado commented Jul 25, 2018 •
edited
Loading

@Trott First and foremost thanks for the feedback!

I've started reading the tools/test.py wrapper, it's a complex file so I'm still trying to understand it. But for what I've gathered isn't there any chance that the tests are run with --timeout=None?

Edit: I've continued reading that file, and found out that on line 1440 all arguments are converted to int therefore one could never set --timeout=None. Please correct me if I'm wrong. Meanwhile I'm going to update the PR.

@conectado
test: update setTimeout to use common.platformTimeout
ef9b217 
Changes the time used by the last line of the file to normalize the timeout
by using the common library.
@conectado
test: remove setTimeout from the file
dbfffbf 
Removes the setTimeout since if the test were to fail it would time out
due to the tools/test.py wrapper
@Trott
Copy link
Member

Trott commented Jul 25, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/16008/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 25, 2018
@conectado
Copy link
Contributor Author

I updated the PR, since the constant TIMEOUT has been left unused I removed it.

maclover7
maclover7 approved these changes Jul 26, 2018
View reviewed changes
Copy link
Contributor

@maclover7 maclover7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and welcome!

@Trott
Copy link
Member

Trott commented Jul 26, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/355/

Internet tests CI: https://ci.nodejs.org/job/node-test-commit-custom-suites/210/

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 26, 2018
@Trott
Copy link
Member

Trott commented Jul 26, 2018

👍 here to fast-track.

@Trott
Copy link
Member

Trott commented Jul 26, 2018

Landed in 586a7a4.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Jul 26, 2018
@richardlau
Copy link
Member

Landed in 586a7a4.

@Trott Did this actually land? I don't see it on the master branch in the GitHub web UI.

Trott pushed a commit to Trott/io.js that referenced this pull request Jul 26, 2018
@conectado @Trott
test: remove setTimeout in test-net-connect-unref
586a7a4 
Removes the setTimeout since if the test were to fail it would time out
due to the tools/test.py wrapper

PR-URL: nodejs#21969
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member

Trott commented Jul 26, 2018 •
edited
Loading

@Trott Did this actually land? I don't see it on the master branch in the GitHub web UI.

@richardlau Ugh, I forgot to push it. It's pushed now. (Thanks!)

@Trott
Copy link
Member

Trott commented Jul 26, 2018

Landed in 586a7a4.

@conectado
Copy link
Contributor Author

Thanks everyone!!

targos pushed a commit that referenced this pull request Jul 31, 2018
@conectado @targos
test: remove setTimeout in test-net-connect-unref
61ae592 
Removes the setTimeout since if the test were to fail it would time out
due to the tools/test.py wrapper

PR-URL: #21969
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@maclover7 maclover7 maclover7 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@conectado @Trott @richardlau @apapirovski @lpinca @maclover7 @nodejs-github-bot