Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add crypto check to build targets #22148

Closed
wants to merge 4 commits into from

Commits on Aug 6, 2018

  1. build: add crypto check to build targets

    Currently when configured without-ssl the build will fail when trying
    to run the tools/doc/node_modules, and .docbuildstamp make targets:
    
    internal/util.js:97
        throw new ERR_NO_CRYPTO();
        ^
    Error [ERR_NO_CRYPTO]: Node.js is not compiled with OpenSSL crypto
                           support
        at assertCrypto (internal/util.js:97:11)
        at crypto.js:31:1
        ...
        at Object.<anonymous>
           (/node/deps/npm/node_modules/uuid/lib/rng.js:4:14)
        at Module._compile (internal/modules/cjs/loader.js:689:30)
        ...
    make[1]: *** [tools/doc/node_modules] Error 1
    
    This commit adds crypto check to these targets to allow the build to
    pass.
    danbev committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    2a10c51 View commit details
    Browse the repository at this point in the history
  2. test: move require of http2 to after crypto check

    Currently when configured without-ssl test-heapdump-http2.js will fail
    with a missing crypto message.
    This commit moves the require of http2 to after the crypto check.
    danbev committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    d625223 View commit details
    Browse the repository at this point in the history
  3. test: move require of https to after crypto check

    Currently when configured without-ssl test-request-arguments.js will
    fail with a missing crypto message.
    This commit moves the require of https to after the crypto check.
    danbev committed Aug 6, 2018
    Configuration menu
    Copy the full SHA
    f1784a4 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2018

  1. squash: move declaration of node_use_openssl

    This commit moves the declaration of node_use_openssl so that it comes
    before the first usage as it needs to be available to the ifeq
    conditions.
    danbev committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    beca02d View commit details
    Browse the repository at this point in the history