Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add gdams to collaborators #22236

Closed
wants to merge 1 commit into from
Closed

doc: add gdams to collaborators #22236

wants to merge 1 commit into from

Conversation

gdams
Copy link
Member

@gdams gdams commented Aug 10, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 10, 2018
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want a space after the email address :)

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, welcome :)

@gdams
Copy link
Member Author

gdams commented Aug 10, 2018

New CI run after addressing changes: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/492/

@gdams gdams added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 10, 2018
@richardlau richardlau added the notable-change PRs with changes that should be highlighted in changelogs. label Aug 10, 2018
@gdams
Copy link
Member Author

gdams commented Aug 10, 2018

landed as: 91e897a

@gdams gdams closed this Aug 10, 2018
gdams pushed a commit that referenced this pull request Aug 10, 2018
PR-URL: #22236
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
@gdams gdams deleted the onboard branch August 10, 2018 17:17
targos pushed a commit that referenced this pull request Aug 11, 2018
PR-URL: #22236
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants