Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util,assert: fix boxed primitives bug #22243

Closed
wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

Currently the comparison could throw an error in case a boxed
primitive has no valueOf function on one side of the assert call.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Currently the comparison could throw an error in case a boxed
primitive has no valueOf function on one side of the assert call.
@nodejs-github-bot nodejs-github-bot added the util Issues and PRs related to the built-in util module. label Aug 10, 2018
@lpinca
Copy link
Member

lpinca commented Aug 10, 2018

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 10, 2018
@trivikr
Copy link
Member

trivikr commented Aug 12, 2018

@gdams
Copy link
Member

gdams commented Aug 12, 2018

landed in: c7ca199

@gdams gdams closed this Aug 12, 2018
gdams pushed a commit that referenced this pull request Aug 12, 2018
Currently the comparison could throw an error in case a boxed
primitive has no valueOf function on one side of the assert call.

PR-URL: #22243
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
rvagg pushed a commit that referenced this pull request Aug 13, 2018
Currently the comparison could throw an error in case a boxed
primitive has no valueOf function on one side of the assert call.

PR-URL: #22243
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
@BridgeAR BridgeAR deleted the fix-boxed-bug branch January 20, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants