Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: refactor options parsing #22392

Closed
wants to merge 4 commits into from
Closed

Commits on Aug 18, 2018

  1. src: refactor options parsing

    This is a major refactor of our Node’s parser. See `node_options.cc`
    for how it is used, and  `node_options-inl.h` for the bulk
    of its implementation.
    
    Unfortunately, the implementation has come to have some
    complexity, in order to meet the following goals:
    
    - Make it easy to *use* for defining or changing options.
    - Keep it (mostly) backwards-compatible.
      - No tests were harmed as part of this commit.
    - Be as consistent as possible.
      - In particular, options can now generally accept arguments
        through both `--foo=bar` notation and `--foo bar` notation.
        We were previously very inconsistent on this point.
    - Separate into different levels of scope, namely
      per-process (global), per-Isolate and per-Environment
      (+ debug options).
    - Allow programmatic accessibility in the future.
      - This includes a possible expansion for `--help` output.
    
    This commit also leaves a number of `TODO` comments, mostly for
    improving consistency even more (possibly with having to modify
    tests), improving embedder support, as well as removing pieces of
    exposed configuration variables that should never have become
    part of the public API but unfortunately are at this point.
    addaleax committed Aug 18, 2018
    Configuration menu
    Copy the full SHA
    5d12355 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3c9b03a View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2018

  1. Configuration menu
    Copy the full SHA
    9b811b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    be4a3b6 View commit details
    Browse the repository at this point in the history