timers: improve Timer.now() performance #2256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
added
the
timers
|
Slick job. LGTM. |
| var assert = require('assert'); | ||
|
|
||
| // Return value of Timer.now() should easily fit in a SMI right after start-up. | ||
| var Timer = process.binding('timer_wrap').Timer; |
PR-URL: nodejs#2256 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: nodejs#2256 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: nodejs#2256 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Record the start time so we can make the return value of Timer.now() relative to it, increasing the chances that it fits in a tagged integer instead of a heap-allocated double, at least for the first one or two billion milliseconds. PR-URL: nodejs#2256 Reviewed-By: Trevor Norris <trev.norris@gmail.com>
bnoordhuis
force-pushed
the
optimize-timer-now
branch
from
fd615bd
to
543dabb
Compare
|
Thanks, landed in 503b089...543dabb with const-ification of the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Record the start time so we can make the return value of Timer.now()
relative to it, increasing the chances that it fits in a tagged integer
instead of a heap-allocated double, at least for the first one or two
billion milliseconds.
R=@trevnorris?
CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/203/