Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: bump ICU from 54 to 55 #2293

Closed
wants to merge 1 commit into from
Closed

build: bump ICU from 54 to 55 #2293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,9 +796,9 @@ def glob_to_var(dir_base, dir_sub):
def configure_intl(o):
icus = [
{
'url': 'http://download.icu-project.org/files/icu4c/54.1/icu4c-54_1-src.zip',
# from https://ssl.icu-project.org/files/icu4c/54.1/icu4c-src-54_1.md5:
'md5': '6b89d60e2f0e140898ae4d7f72323bca',
'url': 'http://download.icu-project.org/files/icu4c/55.1/icu4c-55_1-src.zip',
# from https://ssl.icu-project.org/files/icu4c/55.1/icu4c-src-55_1.md5:
'md5': '4cddf1e1d47622fdd9de2cd7bb5001fd',
},
]
def icu_download(path):
Expand Down
8 changes: 4 additions & 4 deletions tools/icu/icu-generic.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,8 @@
'<@(icu_src_i18n)'
],
'conditions': [
[ 'icu_ver_major == 54', { 'sources!': [
## Strip out the following for ICU 54 only.
[ 'icu_ver_major == 55', { 'sources!': [
## Strip out the following for ICU 55 only.
## add more conditions in the future?
## if your compiler can dead-strip, this will
## make ZERO difference to binary size.
Expand Down Expand Up @@ -369,8 +369,8 @@
'<@(icu_src_common)',
],
'conditions': [
[ 'icu_ver_major == 54', { 'sources!': [
## Strip out the following for ICU 54 only.
[ 'icu_ver_major == 55', { 'sources!': [
## Strip out the following for ICU 55 only.
## add more conditions in the future?
## if your compiler can dead-strip, this will
## make ZERO difference to binary size.
Expand Down