Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timers: use custom inspection for linked lists #23108

Closed
wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

Inspecting linked lists is something that is not really useful.
Instead, just use a custom inspection function and hide everything
besides the first level.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. label Sep 26, 2018
Inspecting linked lists is something that is not really useful.
Instead, just use a custom inspection function and hide everything
besides the first level.
Copy link
Contributor

@Fishrock123 Fishrock123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM although it'd be nice if there was a way to only ignore [TimersList]s here. If a user attaches an object it should probably still inspect as normal...

@BridgeAR
Copy link
Member Author

@Fishrock123 it would be possible inspecting the object deeper using customInspect = false as option. I guess that might be sufficient since most users probably not extent the objects? Otherwise I can only think about manipulating the actual object to achieve that.

@BridgeAR
Copy link
Member Author

@nodejs/timers @nodejs/util PTAL

@danbev
Copy link
Contributor

danbev commented Oct 1, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17545/ ✔️ (besides Windows fanned)

@BridgeAR
Copy link
Member Author

BridgeAR commented Oct 1, 2018

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 1, 2018
@danbev
Copy link
Contributor

danbev commented Oct 2, 2018

Landed in d8baf67.

@danbev danbev closed this Oct 2, 2018
danbev pushed a commit that referenced this pull request Oct 2, 2018
Inspecting linked lists is something that is not really useful.
Instead, just use a custom inspection function and hide everything
besides the first level.

PR-URL: #23108
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
targos pushed a commit that referenced this pull request Oct 3, 2018
Inspecting linked lists is something that is not really useful.
Instead, just use a custom inspection function and hide everything
besides the first level.

PR-URL: #23108
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants