Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: make req_wrap a unique_ptr in AfterConnect #23115

Closed
wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Sep 27, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. net Issues and PRs related to the net subsystem. labels Sep 27, 2018
@danbev
Copy link
Contributor Author

danbev commented Sep 27, 2018

@gireeshpunathil
Copy link
Member

On a slightly un-related note; what is the general convention on the responsibility of deleting heap objects - is it rested with the caller or callee (creator or consumer) ? or is it decided on a case basis? In the absence of a clear guidance, spotting memory leaks may be difficult?

@danbev
Copy link
Contributor Author

danbev commented Sep 27, 2018

is it rested with the caller or callee (creator or consumer) ? or is it decided on a case basis?

I would say that it depends on the situation and who owns the pointer, so it would be on a case basis I think.

@danbev danbev force-pushed the connection_wrap_unique_ptr branch 2 times, most recently from 7b202f3 to 312c959 Compare September 28, 2018 03:38
@danbev
Copy link
Contributor Author

danbev commented Sep 28, 2018

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 30, 2018
@addaleax
Copy link
Member

@danbev
Copy link
Contributor Author

danbev commented Oct 1, 2018

Re-run of failing node-test-commit-windows-fanned/ ✔️

@danbev
Copy link
Contributor Author

danbev commented Oct 1, 2018

Landed in 5c855a7.

@danbev danbev closed this Oct 1, 2018
@danbev danbev deleted the connection_wrap_unique_ptr branch October 1, 2018 06:33
danbev added a commit that referenced this pull request Oct 1, 2018
PR-URL: #23115
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 1, 2018
PR-URL: #23115
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 3, 2018
PR-URL: #23115
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. net Issues and PRs related to the net subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants