Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: unify .editorconfig rules for 2-space #23163

Closed
wants to merge 1 commit into from

Conversation

silverwind
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

The doc directory had not had any editorconfig rules applied which can lead to tab indentation in editors. This unifies the rules to use 2-space as the default. Additionally, all rules are now sorted alphabetically.

The `doc` directory had not had any editorconfig rules applied which can
lead to tab indentation in editors. This unifies the rules to use 2-space
as the default. Additionally, all rules are now sorted alphabetically.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 29, 2018
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 1, 2018
@silverwind
Copy link
Contributor Author

Landed in 6ea507a.

@silverwind silverwind closed this Oct 1, 2018
@silverwind silverwind deleted the editorconfig branch October 1, 2018 16:45
silverwind added a commit that referenced this pull request Oct 1, 2018
The `doc` directory had not had any editorconfig rules applied which can
lead to tab indentation in editors. This unifies the rules to use 2-space
as the default. Additionally, all rules are now sorted alphabetically.

PR-URL: #23163
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Oct 3, 2018
The `doc` directory had not had any editorconfig rules applied which can
lead to tab indentation in editors. This unifies the rules to use 2-space
as the default. Additionally, all rules are now sorted alphabetically.

PR-URL: #23163
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants