Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: simplify support section of README #23170

Closed
wants to merge 1 commit into from
Closed

doc: simplify support section of README #23170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ When looking for support, please first search for your question in these venues:
* [Node.js Help][]
* [Open or closed issues in the Node.js GitHub organization](https://github.com/issues?utf8=%E2%9C%93&q=sort%3Aupdated-desc+org%3Anodejs+is%3Aissue)

If you didn't find an answer in one of the official resources above, you can
search these unofficial resources:
If you didn't find an answer in the resources above, try these unofficial
resources:

* [Questions tagged 'node.js' on StackOverflow][]
* [#node.js channel on chat.freenode.net][]. See <http://nodeirc.info/> for more
Expand All @@ -59,11 +59,11 @@ search these unofficial resources:
* [Node.js Slack Community](https://node-js.slack.com/): Visit
[nodeslackers.com](http://www.nodeslackers.com/) to register.

GitHub issues are meant for tracking enhancements and bugs, not general support.
GitHub issues are for tracking enhancements and bugs, not general support.

Remember, libre != gratis; the open source license grants you the freedom to use
and modify, but not commitments of other people's time. Please be respectful,
and set your expectations accordingly.
The open source license grants you the freedom to use Node.js. It does not
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the and modify bit here could stay?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking was that the MIT license says all of this:

use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies

I understand why we'd select use from that list, but it's less clear why we'd also include modify over copy or distribute. Just sticking with use seemed simplest and best.

So that was my thinking. If that's not persuasive, I'll restore and modify to the text.

Copy link
Contributor

@refack refack Sep 30, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe /s/modify/fix/ might give the reader the hint we imply ;)
(or "tweak")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trott That’s okay with me, yeah… I guess I’ve thought that modify would be the least likely of the verbs you used for which it would be assumed that it’s okay to do?

guarantee commitments of other people's time. Please be respectful and manage
your expectations.

## Release Types

Expand Down