Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2018-10-30 Version 10.13.0 'Dubnium' (LTS) #23831

Merged
merged 4 commits into from
Oct 30, 2018
Merged

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Oct 23, 2018

2018-10-30, Version 10.13.0 'Dubnium' (LTS), @MylesBorins

This release marks the transition of Node.js 10.x into Long Term
Support (LTS) with the codename 'Dubnium'. The 10.x release line
now moves in to "Active LTS" and will remain so until April 2020.
After that time it will move in to "Maintenance" until end of
life in April 2021.

Notable Changes

This release only includes minimal changes necessary to fix known regressions prior to LTS.

Commits

  • [2ba6010082] - buffer: fix crash for invalid index types (Anna Henningsen)
  • [2cd68be69d] - build: spawn make test-ci with -j1 (Refael Ackermann) #23733
  • [1003f4c975] - deps: fix wrong default for v8 handle zapping (Refael Ackermann) #23801

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. v10.x labels Oct 23, 2018
@MylesBorins
Copy link
Contributor Author

@nodejs/release please lmk if you think we should include any changes in this release... we currently have a fairly decent backlog on staging, which I think includes semver-minor changes. While we could include them in this release it would arguably be against our LTS policy (as changes will not have been in a release for 2 weeks). We do not, afaik, have explicit policy around the initial LTS release... but have discussed in the past releasing only the bit flip to LTS rather than accompanying it with other changes

@targos
Copy link
Member

targos commented Oct 23, 2018

I'm +1 on a release with minimal changes.

We should include #23801 when it lands

@mhdawson
Copy link
Member

Test is failing because it needs to be aware of the new release

// it's expected that future LTS release lines will have additional
// branches in here
if (versionParts[0] === '4' && versionParts[1] >= 2) {
  assert.strictEqual(process.release.lts, 'Argon');
} else if (versionParts[0] === '6' && versionParts[1] >= 9) {
  assert.strictEqual(process.release.lts, 'Boron');
} else if (versionParts[0] === '8' && versionParts[1] >= 9) {
  assert.strictEqual(process.release.lts, 'Carbon');
} else {
  assert.strictEqual(process.release.lts, undefined);
}

Missing the else if for 10

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once test is updated.

#define NODE_VERSION_IS_LTS 0
#define NODE_VERSION_LTS_CODENAME ""
#define NODE_VERSION_IS_LTS 1
#define NODE_VERSION_LTS_CODENAME "dubnium"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This codename is uppercased in Boron and Carbon. Is there a reason for a change to this naming pattern?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@cxreg
Copy link
Contributor

cxreg commented Oct 23, 2018

@MylesBorins did you intend to rebase to v10.x-staging with that last commit?

@MylesBorins
Copy link
Contributor Author

@cxreg I didn't, thanks for the due diligence

@targos
Copy link
Member

targos commented Oct 24, 2018

Another change that should be included IMO: #23795

@srl295
Copy link
Member

srl295 commented Oct 24, 2018

edit no notable changes… OK, this can be next time.

maybe some ICU <3 ? in decreasing order of importance

Easily skip this one if ICU 63.1 lands:

@bnb
Copy link
Contributor

bnb commented Oct 25, 2018

Thank you for your work on this @MylesBorins ❤️

I also very much appreciate the precedent of "no changes" outside of a SemVer minor patch. Feels much tidier and provides a simple way to explain the change to people.

@MylesBorins
Copy link
Contributor Author

@targos I've landed #23801 and am waiting to see what happens in #23795

@srl295 I'm going to push back on landing any of the changes you've outlined here. As we are keeping this release targeting to minimal changes. I'd like to see the changes above live in an 11.x release before landing them in LTS

PR-URL: #23801
Fixes: #23796
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
@cujarrett
Copy link

cujarrett commented Oct 28, 2018

🎉 Thanks Node contributors and maintainers! 🎉

All the sub targets have internal parallelism, so no performance loss.
Also `make` doesn't to a good enough job of combining the output
streams, or eliminate races.

PR-URL: #23733
Fixes: #22006
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
2555cb4 introduced a crash
when a non-number value was passed to `ParseArrayIndex()`.

We do not always have JS typechecking for that in place, though.
This returns back to the previous behavior of coercing values
to integers, which is certainly questionable.

Refs: #22129
Fixes: #23668
@MylesBorins
Copy link
Contributor Author

updated with two more commits to fix known regressions. Kicking off one last round of CI

CI: https://ci.nodejs.org/job/node-test-pull-request/18216/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1605/
rc.2: https://nodejs.org/download/rc/v10.13.0-rc.2/

@MylesBorins
Copy link
Contributor Author

This release marks the transition of Node.js 10.x into Long Term
Support (LTS) with the codename 'Dubnium'. The 10.x release line
now moves in to "Active LTS" and will remain so until April 2020.
After that time it will move in to "Maintenance" until end of
life in April 2021.

Notable Changes:

This release only includes minimal changes necessary to fix known
regressions prior to LTS.

PR-URL: #23831
@MylesBorins MylesBorins merged commit ab4af08 into v10.x Oct 30, 2018
MylesBorins added a commit that referenced this pull request Oct 30, 2018
pull bot pushed a commit to shakir-abdo/node that referenced this pull request Oct 30, 2018
This release marks the transition of Node.js 10.x into Long Term
Support (LTS) with the codename 'Dubnium'. The 10.x release line
now moves in to "Active LTS" and will remain so until April 2020.
After that time it will move in to "Maintenance" until end of
life in April 2021.

Notable Changes:

This release only includes minimal changes necessary to fix known
regressions prior to LTS.

PR-URL: nodejs#23831
@targos
Copy link
Member

targos commented Oct 30, 2018

🎉 🎉 🎉

@joshgav
Copy link
Contributor

joshgav commented Oct 30, 2018

Thanks @MylesBorins! I think you still need to add a latest-dubnium folder to https://nodejs.org/dist/.

@richardlau
Copy link
Member

Thanks @MylesBorins! I think you still need to add a latest-dubnium folder to https://nodejs.org/dist/.

Opened nodejs/nodejs-latest-linker#2 against the linker tool.

@MylesBorins
Copy link
Contributor Author

I manually created https://nodejs.org/download/release/latest-dubnium/ but we still need to update the automation script

@targos targos deleted the v10.13.0-proposal branch October 31, 2018 08:38
@rvagg
Copy link
Member

rvagg commented Oct 31, 2018

latest-linker updated and deployed, thanks @richardlau for the code and @joshgav for the ping

@codebytere codebytere mentioned this pull request Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.