Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: remove obsolete function escapeHeaderValue #24173

Closed
wants to merge 1 commit into from

Conversation

lauripiisang
Copy link
Contributor

  • there are test cases which validate the useful
    path of the function never runs
  • the functionality of it is obsoleted by
    checkInvalidHeaderChar in addTrailers and storeHeader
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

 - there are test cases which validate the useful
   path of the function never runs
 - the functionality of it is obsoleted by
   checkInvalidHeaderChar
@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Nov 6, 2018
@addaleax addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2018
@jasnell
Copy link
Member

jasnell commented Nov 9, 2018

CI will be https://ci.nodejs.org/job/node-test-pull-request/1​84​59 once the CI is able to catch up on it's existing jobs.

@gireeshpunathil
Copy link
Member

failure is a border case (same module, but only affecting freebsd); so running CI once again on the benefit of doubt:
Resume CI: https://ci.nodejs.org/job/node-test-commit/23142/

@gireeshpunathil
Copy link
Member

landed as 117fef4 , thanks!

gireeshpunathil pushed a commit that referenced this pull request Nov 13, 2018
There are test cases which validate the useful path of the function
never runs the functionality of it is obsoleted by
checkInvalidHeaderChar

PR-URL: #24173
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
There are test cases which validate the useful path of the function
never runs the functionality of it is obsoleted by
checkInvalidHeaderChar

PR-URL: #24173
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
There are test cases which validate the useful path of the function
never runs the functionality of it is obsoleted by
checkInvalidHeaderChar

PR-URL: nodejs#24173
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere pushed a commit that referenced this pull request Jan 12, 2019
There are test cases which validate the useful path of the function
never runs the functionality of it is obsoleted by
checkInvalidHeaderChar

PR-URL: #24173
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. http Issues or PRs related to the http subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants