Revert "util: change util.inspect depth default" #24326
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
repl
This reverts commit ac7450a. This fully reverts the changes to util.inspect depth. It has caused breakage in logging to existing apps, and even something as simple as `console.log(require)` will cause >1m freezes. I've heard nothing but negative feedback (seriously not a single person has expressed anything positive about this change) and personally i find this change extremely annoying.
devsnek
force-pushed
the
revert/ac7450a09a4c167cd43c14d7c88721d22f077529
branch
from
4ef10a3
to
bde132b
Compare
devsnek
changed the title
addaleax
approved these changes
Nov 12, 2018
cjihrig
approved these changes
Nov 12, 2018
devsnek
added
the
author ready
fhinkel
approved these changes
Nov 12, 2018
targos
approved these changes
Nov 13, 2018
|
I was not aware that #23350 never landed. Shall we go for that instead or shall we revert everything fully first? I am fine either way as I intend to do a breadth wide inspection instead of the current inspection which allows to check for the actual lines being printed and therefore have a reasonable way to limit the output. The implementation is just not that trivial. |
|
@BridgeAR I'd prefer it go all the way back to 2, and then we can work our way up if that is deemed the best direction. |
BridgeAR
approved these changes
Nov 14, 2018
jdalton
approved these changes
Nov 14, 2018
|
Landed in 7082c61 |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 15, 2018
This reverts commit ac7450a. This fully reverts the changes to util.inspect depth. It has caused breakage in logging to existing apps, and even something as simple as `console.log(require)` will cause >1m freezes. I've heard nothing but negative feedback (seriously not a single person has expressed anything positive about this change) and personally i find this change extremely annoying. PR-URL: nodejs#24326 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
devsnek
removed
the
author ready
BridgeAR
added
the
notable-change
|
It would have been good to include the other commit from the original PR as well. Otherwise the default depth for the |
|
@BridgeAR I left that commit out on purpose, as it wasn't breaking anything and seems reasonable to not override anything. |
|
It was my intention to release it but it broke tests without the other commit backported as well. That's why I pulled it out again as I did not want to block the release. So there is no disagreement here. |
|
What's the next step here? Open a backport PR for v11.x that includes a revert of the other commit? |
|
i'm not really sure. apparently some tests are failing on 11.x that aren't failing on master 🤷♂️ |
4 tasks
BridgeAR
added a commit
that referenced
this pull request
Dec 5, 2018
Notable Changes: * util: The inspection `depth` default is now back at 2. #24326 * Added new collaborator: [antsmartian](https://github.com/antsmartian) - Anto Aravinth. #24655
BridgeAR
added a commit
that referenced
this pull request
Dec 5, 2018
Notable Changes: * util: The inspection `depth` default is now back at 2. #24326 * Added new collaborator: [antsmartian](https://github.com/antsmartian) - Anto Aravinth. #24655
BridgeAR
added a commit
that referenced
this pull request
Dec 6, 2018
Notable Changes: * util: The inspection `depth` default is now back at 2. #24326 * Added new collaborator: [antsmartian](https://github.com/antsmartian) - Anto Aravinth. #24655 PR-URL: #24854
BridgeAR
added a commit
that referenced
this pull request
Dec 6, 2018
Notable Changes:
* console,util:
* `console` functions now handle symbols as defined in the spec.
#23708
* The inspection `depth` default is now back at 2.
#24326
* dgram,net:
* Added ipv6Only option for `net` and `dgram`.
#23798
* http:
* Chosing between the http parser is now possible per runtime flag.
#24739
* readline:
* The `readline` module now supports async iterators.
#23916
* repl:
* The multiline history feature is removed.
#24804
* tls:
* Added min/max protocol version options.
#24405
* The X.509 public key info now includes the RSA bit size and the
elliptic curve. #24358
* url:
* `pathToFileURL()` now supports LF, CR and TAB.
#23720
* Windows:
* Tools are not installed using Boxstarter anymore.
#24677
* The install-tools scripts or now included in the dist.
#24233
* Added new collaborator:
* [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
#24655
PR-URL: #24854
BridgeAR
added a commit
that referenced
this pull request
Dec 7, 2018
Notable Changes:
* console,util:
* `console` functions now handle symbols as defined in the spec.
#23708
* The inspection `depth` default is now back at 2.
#24326
* dgram,net:
* Added ipv6Only option for `net` and `dgram`.
#23798
* http:
* Chosing between the http parser is now possible per runtime flag.
#24739
* readline:
* The `readline` module now supports async iterators.
#23916
* repl:
* The multiline history feature is removed.
#24804
* tls:
* Added min/max protocol version options.
#24405
* The X.509 public key info now includes the RSA bit size and the
elliptic curve. #24358
* url:
* `pathToFileURL()` now supports LF, CR and TAB.
#23720
* Windows:
* Tools are not installed using Boxstarter anymore.
#24677
* The install-tools scripts or now included in the dist.
#24233
* Added new collaborator:
* [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
#24655
PR-URL: #24854
BridgeAR
added a commit
that referenced
this pull request
Dec 7, 2018
Notable Changes:
* console,util:
* `console` functions now handle symbols as defined in the spec.
#23708
* The inspection `depth` default is now back at 2.
#24326
* dgram,net:
* Added ipv6Only option for `net` and `dgram`.
#23798
* http:
* Chosing between the http parser is now possible per runtime flag.
#24739
* readline:
* The `readline` module now supports async iterators.
#23916
* repl:
* The multiline history feature is removed.
#24804
* tls:
* Added min/max protocol version options.
#24405
* The X.509 public key info now includes the RSA bit size and the
elliptic curve. #24358
* url:
* `pathToFileURL()` now supports LF, CR and TAB.
#23720
* Windows:
* Tools are not installed using Boxstarter anymore.
#24677
* The install-tools scripts or now included in the dist.
#24233
* Added new collaborator:
* [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
#24655
PR-URL: #24854
This was referenced Dec 7, 2018
|
Did anyone actually checked the claim that |
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Notable Changes:
* console,util:
* `console` functions now handle symbols as defined in the spec.
nodejs#23708
* The inspection `depth` default is now back at 2.
nodejs#24326
* dgram,net:
* Added ipv6Only option for `net` and `dgram`.
nodejs#23798
* http:
* Chosing between the http parser is now possible per runtime flag.
nodejs#24739
* readline:
* The `readline` module now supports async iterators.
nodejs#23916
* repl:
* The multiline history feature is removed.
nodejs#24804
* tls:
* Added min/max protocol version options.
nodejs#24405
* The X.509 public key info now includes the RSA bit size and the
elliptic curve. nodejs#24358
* url:
* `pathToFileURL()` now supports LF, CR and TAB.
nodejs#23720
* Windows:
* Tools are not installed using Boxstarter anymore.
nodejs#24677
* The install-tools scripts or now included in the dist.
nodejs#24233
* Added new collaborator:
* [antsmartian](https://github.com/antsmartian) - Anto Aravinth.
nodejs#24655
PR-URL: nodejs#24854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ac7450a.
It has caused breakage in logging to existing apps, and even
something as simple as
console.log(require)will cause >1m freezes.I've heard nothing but negative feedback (seriously not a single
person has expressed anything positive about this change) and
personally i find this change extremely annoying while debugging.
cc @nodejs/util
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes