Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net,http2: merge after-write code #24380

Closed
wants to merge 1 commit into from
Closed

net,http2: merge after-write code #24380

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Refs: #19060

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1621/pipeline

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Nov 15, 2018
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/18652/

@addaleax addaleax added net Issues and PRs related to the net subsystem. http2 Issues or PRs related to the http2 subsystem. and removed lib / src Issues and PRs related to general changes in the lib or src directory. labels Nov 15, 2018
@Trott
Copy link
Member

Trott commented Nov 18, 2018

@nodejs/http2 This could use some reviews.

@danbev
Copy link
Contributor

danbev commented Nov 21, 2018

Landed in 8dd8b8f.

@danbev danbev closed this Nov 21, 2018
danbev pushed a commit that referenced this pull request Nov 21, 2018
@addaleax @danbev
net,http2: merge after-write code
8dd8b8f 
PR-URL: #24380
Refs: #19060
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
targos pushed a commit that referenced this pull request Nov 21, 2018
@addaleax @targos
net,http2: merge after-write code
6e032dc 
PR-URL: #24380
Refs: #19060
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@addaleax @rvagg
net,http2: merge after-write code
24acd53 
PR-URL: #24380
Refs: #19060
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
@codebytere
Copy link
Member

@addaleax do you think this can/should be backported to v10.x? I've added a label, but feel free to remove it!

refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@refack
net,http2: merge after-write code
7cce7fa 
PR-URL: nodejs#24380
Refs: nodejs#19060
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@addaleax @nodejs-github-bot @Trott @danbev @codebytere @jasnell