Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaced the pattern to (args)=> #24434

Closed
wants to merge 1 commit into from
Closed

replaced the pattern to (args)=> #24434

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions test/parallel/test-https-close.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,16 @@ const options = {

const connections = {};

const server = https.createServer(options, function(req, res) {
const interval = setInterval(function() {
const server = https.createServer(options, (req, res) => {
const interval = setInterval(() => {
res.write('data');
}, 1000);
interval.unref();
});

server.on('connection', function(connection) {
server.on('connection', (connection) => {
const key = `${connection.remoteAddress}:${connection.remotePort}`;
connection.on('close', function() {
connection.on('close', () => {
delete connections[key];
});
connections[key] = connection;
Expand All @@ -37,16 +37,16 @@ function shutdown() {
}
}

server.listen(0, function() {
server.listen(0, () => {
const requestOptions = {
hostname: '127.0.0.1',
port: this.address().port,
port: server.address().port,
path: '/',
method: 'GET',
rejectUnauthorized: false
};

const req = https.request(requestOptions, function(res) {
const req = https.request(requestOptions, (res) => {
res.on('data', () => {});
setImmediate(shutdown);
});
Expand Down