doc: revise accepting-modifications in guide #24650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Trott sadly an error occured when I tried to trigger a build :( |
cjihrig
approved these changes
Nov 26, 2018
targos
approved these changes
Nov 26, 2018
richardlau
reviewed
Nov 26, 2018
COLLABORATOR_GUIDE.md
Outdated
| landed into the codebase. There may be exceptions to the latter (the changed | ||
| code cannot be tested with a CI or similar). If that is the case, please leave a | ||
| comment that explains why the PR does not require a CI run. | ||
| All modifications to Node.js start as GitHub pull requests. This includes |
There was a problem hiding this comment.
This is less accurate than the original. Some modifications start from issues, even if they ultimately end up as being made via pull requests.
lpinca
approved these changes
Nov 26, 2018
fhinkel
approved these changes
Nov 27, 2018
Revise the "Accepting Modifications" section of the Collaborator Guide.
|
@richardlau I think I addressed both of your comments. PTAL. Thanks. |
richardlau
approved these changes
Nov 28, 2018
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 28, 2018
Revise the "Accepting Modifications" section of the Collaborator Guide. PR-URL: nodejs#24650 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
|
Landed in 7d18e92 |
targos
pushed a commit
that referenced
this pull request
Nov 28, 2018
Revise the "Accepting Modifications" section of the Collaborator Guide. PR-URL: #24650 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Revise the "Accepting Modifications" section of the Collaborator Guide. PR-URL: nodejs#24650 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
Revise the "Accepting Modifications" section of the Collaborator Guide. PR-URL: #24650 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
Revise the "Accepting Modifications" section of the Collaborator Guide. PR-URL: #24650 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise the "Accepting Modifications" section of the Collaborator Guide.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes