inspector,vm: remove --eval wrapper #25832
Conversation
Report the actual source code when running with `--eval` and `--inspect-brk`, by telling the vm module to break on the first line of the script being executed rather than wrapping the source code in a function.
addaleax
added
vm
nodejs-github-bot
added
c++
| filename: ${JSON.stringify(name)}, | ||
| displayErrors: true, | ||
| [kVmBreakFirstLineSymbol]: ${!!breakFirstLine} | ||
| });\n`; |
There was a problem hiding this comment.
@addaleax The kVmBreakFirstLineSymbol looks pretty handy. Is there a reason to keep it hidden and not exposed as a user facing option like a boolean breakFirstLineSymbol options property?
There was a problem hiding this comment.
@jdalton Err, it’s less work for this PR? 😄 I’m not sure, but I guess it also only works while the inspector is enabled, similar to debugger; statements?
Somebody from @nodejs/v8-inspector might know more.
There was a problem hiding this comment.
Supersedes #24946 (which uses debugger;), this just removes the wrapper entirely so the source panel is cleaner in the inspector UI.
|
@joyeecheung Sorry, I wasn’t aware of that PR – it looks like that mostly consists of test changes that we could still apply, right? |
addaleax
added
the
author ready
|
Landed in cca897e |
Report the actual source code when running with `--eval` and `--inspect-brk`, by telling the vm module to break on the first line of the script being executed rather than wrapping the source code in a function. PR-URL: #25832 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Report the actual source code when running with `--eval` and `--inspect-brk`, by telling the vm module to break on the first line of the script being executed rather than wrapping the source code in a function. PR-URL: #25832 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Report the actual source code when running with
--evaland--inspect-brk, by telling the vm module to break on thefirst line of the script being executed rather than wrapping
the source code in a function.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes