Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add missing pr-url #26753

Closed
wants to merge 1 commit into from
Closed

doc: add missing pr-url #26753

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 18, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2973/pipeline

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Mar 18, 2019
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 18, 2019
@targos
Copy link
Member

targos commented Mar 18, 2019

👍 this comment if you approve fast-tracking

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 18, 2019
@danbev
Copy link
Contributor

danbev commented Mar 19, 2019

CI lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2980/

@danbev
Copy link
Contributor

danbev commented Mar 19, 2019

Landed in cd9898a.

@danbev danbev closed this Mar 19, 2019
danbev pushed a commit that referenced this pull request Mar 19, 2019
@cjihrig @danbev
doc: add missing pr-url
cd9898a 
PR-URL: #26753
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@cjihrig cjihrig deleted the dep-fix branch March 19, 2019 12:51
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@cjihrig @nodejs-github-bot @targos @danbev @jasnell @addaleax @lpinca @richardlau @vsemozhetbyt @ZYSzys