crypto: rename generateKeyPairEdDSA #26900
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that support for X25519 and X448 has been added, this function is not used exclusively for EdDSA keys anymore. Refs: nodejs#26774
nodejs-github-bot
added
c++
bnoordhuis
approved these changes
Mar 25, 2019
jasnell
approved these changes
Mar 25, 2019
BridgeAR
approved these changes
Mar 25, 2019
BridgeAR
added
the
author ready
sam-github
approved these changes
Mar 26, 2019
| publicFormat, publicType, | ||
| privateFormat, privateType, | ||
| cipher, passphrase, wrap); | ||
| impl = (wrap) => generateKeyPairNid(id, |
There was a problem hiding this comment.
not directly related, but it looks to me that id should be nid.
tniessen
added a commit
that referenced
this pull request
Mar 28, 2019
Now that support for X25519 and X448 has been added, this function is not used exclusively for EdDSA keys anymore. PR-URL: #26900 Refs: #26774 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
|
Landed in df1c9eb, thanks for reviewing. |
targos
pushed a commit
that referenced
this pull request
Mar 28, 2019
Now that support for X25519 and X448 has been added, this function is not used exclusively for EdDSA keys anymore. PR-URL: #26900 Refs: #26774 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 5, 2019
Now that support for X25519 and X448 has been added, this function is not used exclusively for EdDSA keys anymore. PR-URL: #26900 Refs: #26774 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
This was referenced Apr 23, 2019
tniessen
removed
the
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that support for X25519 and X448 has been added, this function is not used exclusively for EdDSA keys anymore. "NID" is the term OpenSSL uses for numerical representations of OIDs such as
EVP_PKEY_X448.Refs: #26774
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes