Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: check return value, silence coverity warning #26997

Closed
wants to merge 1 commit into from
Closed

src: check return value, silence coverity warning #26997

wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

No description provided.

@nodejs-github-bot
Copy link
Collaborator

@bnoordhuis Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 29, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 31, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22062/

This was referenced Apr 2, 2019
Closed
Closed
@danbev
Copy link
Contributor

danbev commented Apr 3, 2019 •
edited
Loading

Re-build of failing node-test-commit-freebsd (✔️)
Re-build of failing node-test-commit-linux (✔️)

@danbev
Copy link
Contributor

danbev commented Apr 3, 2019

Landed in 1087805.

@danbev danbev closed this Apr 3, 2019
danbev pushed a commit that referenced this pull request Apr 3, 2019
@bnoordhuis @danbev
src: check return value, silence coverity warning
1087805 
PR-URL: #26997
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 4, 2019
@bnoordhuis @BethGriggs
src: check return value, silence coverity warning
f686200 
PR-URL: #26997
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbev danbev danbev approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bnoordhuis @nodejs-github-bot @danbev @cjihrig @BridgeAR