Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix performance-faster-string-find in node_report.cc #27262

Closed
wants to merge 1 commit into from
Closed

src: fix performance-faster-string-find in node_report.cc #27262

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

See https://ci.nodejs.org/job/node-clang-tidy/7/console.

cc @richardlau @refack

Not sure why not caught by my clang-tidy, which version is Jenkins using ?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report. labels Apr 16, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 16, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22503/

mhdawson
mhdawson approved these changes Apr 18, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22554/

@ZYSzys
Copy link
Member

ZYSzys commented Apr 19, 2019

Landed in 7581910 🎉

@ZYSzys ZYSzys closed this Apr 19, 2019
ZYSzys pushed a commit that referenced this pull request Apr 19, 2019
@gengjiawen @ZYSzys
src: fix performance-faster-string-find in node_report.cc
7581910 
PR-URL: #27262
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@gengjiawen gengjiawen deleted the performance-faster-string-find branch April 19, 2019 03:21
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@mhdawson mhdawson mhdawson approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gengjiawen @nodejs-github-bot @ZYSzys @addaleax @richardlau @BridgeAR @mhdawson