buffer: remove unreachable code #27445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unreachable code from lib/buffer.js.
nodejs-github-bot
added
the
buffer
|
The check for |
targos
approved these changes
Apr 28, 2019
|
CI: https://ci.nodejs.org/job/node-test-pull-request/22752/ (:white_check_mark:) |
Trott
added
the
author ready
ZYSzys
approved these changes
Apr 28, 2019
BridgeAR
approved these changes
Apr 28, 2019
cjihrig
approved these changes
Apr 28, 2019
lpinca
approved these changes
Apr 28, 2019
addaleax
approved these changes
Apr 28, 2019
|
Landed in 524dd46 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 30, 2019
Remove unreachable code from lib/buffer.js. PR-URL: nodejs#27445 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Apr 30, 2019
Remove unreachable code from lib/buffer.js. PR-URL: #27445 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This was referenced May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unreachable code from lib/buffer.js.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes