Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add mustCallAtLeast to test-fs-read-stream-fd test #27461

Closed
wants to merge 1 commit into from
Closed

test: add mustCallAtLeast to test-fs-read-stream-fd test #27461

wants to merge 1 commit into from

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented Apr 28, 2019 •
edited
Loading

From code and learn: nodejs/code-and-learn#94

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Apr 28, 2019
@oyyd oyyd added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Apr 28, 2019
@hardfist
test: add mustCallAtLeast to test-fs-read-stream-fd test
8963852 
Change-Id: Ib74392326ee7471732488c1cf3c32f08685e0439
cjihrig
cjihrig approved these changes Apr 28, 2019
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't necessary, but LGTM.

@ZYSzys ZYSzys added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 28, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22778/

@oyyd
Copy link
Contributor

oyyd commented Apr 28, 2019

please leave 👍 to fast track

@ZYSzys ZYSzys added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 29, 2019
ZYSzys pushed a commit that referenced this pull request Apr 29, 2019
@hardfist @ZYSzys
test: add mustCallAtLeast to test-fs-read-stream-fd test
4cf8b42 
PR-URL: #27461
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@ZYSzys
Copy link
Member

ZYSzys commented Apr 29, 2019

Landed in 4cf8b42 🎉.

Congratulation for your first contribution to Node.js.

You can visit https://www.nodetodo.org/next-steps/ for more ideas to contribute.

@ZYSzys ZYSzys closed this Apr 29, 2019
targos pushed a commit that referenced this pull request Apr 29, 2019
@hardfist @targos
test: add mustCallAtLeast to test-fs-read-stream-fd test
a37ca24 
PR-URL: #27461
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@antsmartian antsmartian antsmartian approved these changes

@yorkie yorkie yorkie approved these changes

@cjihrig cjihrig cjihrig approved these changes

@starkwang starkwang starkwang approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@hardfist @nodejs-github-bot @oyyd @ZYSzys @Trott @antsmartian @yorkie @cjihrig @starkwang