Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make sure weak references are not GCed to early #27482

Closed
wants to merge 2 commits into from
Closed

test: make sure weak references are not GCed to early #27482

wants to merge 2 commits into from

Commits on Apr 30, 2019

  1. test: make sure weak references are not GCed too early 

    This fixes flaky `util.inspect` tests by making sure that the
inspected WeakMap and WeakSet only contains objects that still have
other hard references. Otherwise the garbage collection could collect
these objects to early.
    @BridgeAR
    BridgeAR committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    8cc10b0 View commit details
    Browse the repository at this point in the history

  2. fixup! test: make sure weak references are not GCed too early

    @BridgeAR
    BridgeAR committed Apr 30, 2019
    Configuration menu
    Copy the full SHA
    73d936c View commit details
    Browse the repository at this point in the history