Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpp: make deleted function public #27509

Closed
wants to merge 2 commits into from
Closed

cpp: make deleted function public #27509

wants to merge 2 commits into from

Conversation

gengjiawen
Copy link
Member

Hopefully when #26840 launched, we can find this earlier.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. process Issues and PRs related to the process subsystem. labels May 1, 2019
@addaleax addaleax added lib / src Issues and PRs related to general changes in the lib or src directory. and removed process Issues and PRs related to the process subsystem. labels May 1, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22867/

@danbev danbev added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 6, 2019
@danbev
Copy link
Contributor

danbev commented May 6, 2019

Landed in 64a25b8, and 8c94d5e.

@danbev danbev closed this May 6, 2019
danbev pushed a commit that referenced this pull request May 6, 2019
@gengjiawen @danbev
src: make deleted function public in node_main_instance.h
64a25b8 
PR-URL: #27509
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danbev pushed a commit that referenced this pull request May 6, 2019
@gengjiawen @danbev
src: make deleted function public in node_native_module.h
8c94d5e 
PR-URL: #27509
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request May 6, 2019
@gengjiawen @targos
src: make deleted function public in node_main_instance.h
1489d12 
PR-URL: #27509
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request May 6, 2019
@gengjiawen @targos
src: make deleted function public in node_native_module.h
8724229 
PR-URL: #27509
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gengjiawen @nodejs-github-bot @danbev @bnoordhuis @addaleax