Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributing: Use American English for consistency #2784

Closed
wants to merge 3 commits into from
Closed

Contributing: Use American English for consistency #2784

wants to merge 3 commits into from

Conversation

agcolom
Copy link
Contributor

@agcolom agcolom commented Sep 9, 2015

behaviour -> behavior

@Trott
Copy link
Member

Trott commented Sep 9, 2015

I don't know if there was ever a decision to standardize on US English, but it does appear that there's an even split in that file between behavior and behaviour and I'm all for consistency. So...

LGTM

Optional bonus changes to add: behaviour also appears in doc/api/modules.markdown and doc/api/process.markdown. (Inside doc/api, behavior appears 22 times, so it is definitely the more common of the two in the documentation. The two files with behaviour are outliers in that regard.)

@agcolom
Copy link
Contributor Author

agcolom commented Sep 9, 2015

@Trott cool. Yes I'm a bit OCD with consistency and swing both spellings was bugging me. I can add those in the morning (bedtime now in London and my laptop has run out of power... On my phone now ;-) ). I'll add the changes to this branch first thing in the morning if you're happy with that.

@agcolom
Copy link
Contributor Author

agcolom commented Sep 9, 2015

^ seing, not swing!

@mscdex mscdex added the doc Issues and PRs related to the documentations. label Sep 9, 2015
@brendanashworth
Copy link
Contributor

cc'ing @nodejs/documentation if they want to document the americanization

@agcolom
Copy link
Contributor Author

agcolom commented Sep 10, 2015

@Trott suggested changes have been added.

@brendanashworth
Copy link
Contributor

LGTM

1 similar comment
@targos
Copy link
Member

targos commented Sep 10, 2015

LGTM

@thefourtheye
Copy link
Contributor

I am +0 here. My school taught as 'behaviour' only. But I am okay with either of them.

@Trott
Copy link
Member

Trott commented Sep 10, 2015

Landed in e1fb0e8

@Trott Trott closed this Sep 10, 2015
Trott pushed a commit that referenced this pull request Sep 10, 2015
@agcolom @Trott
doc: use US English for consistency
e1fb0e8 
behaviour -> behavior

PR-URL: #2784
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
rvagg pushed a commit that referenced this pull request Sep 11, 2015
@agcolom @rvagg
doc: use US English for consistency
d664b95 
behaviour -> behavior

PR-URL: #2784
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
rvagg pushed a commit that referenced this pull request Sep 12, 2015
@agcolom @rvagg
doc: use US English for consistency
5e93bc4 
behaviour -> behavior

PR-URL: #2784
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@rvagg rvagg mentioned this pull request Sep 12, 2015
Merged
@Fishrock123 Fishrock123 mentioned this pull request Sep 13, 2015
Closed
7 tasks
@rvagg rvagg mentioned this pull request Sep 22, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@agcolom @Trott @brendanashworth @targos @thefourtheye @mscdex